[refactor]: Remove isSSOEnabled logic throughout the codebase #9462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated all references to `isSSOEnabled` across the frontend, backend, and configuration files. This change simplifies the codebase by removing unnecessary feature flag checks, associated logic, and environment variables. The SSO feature remains available without reliance on this flag.
Log |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@FelixMalfait Do you want a command for the next migration to clean the flag in the database? |
|
Let's wait for the deploy before merging this PR :) |
FelixMalfait
reviewed
Jan 9, 2025
| export * from './animated-expandable-container/types/AnimationSize'; | ||
| export * from './animated-expandable-container/utils/getCommonStyles'; | ||
| export * from './animated-expandable-container/utils/getExpandableAnimationConfig'; | ||
| export * from './animated-expandable-container/utils/getTransitionValues'; |
There was a problem hiding this comment.
Not sure what this is / why this is part of this PR?
There was a problem hiding this comment.
You're right. Weird. I remove that
Remove redundant exports related to animated expandable container types and utils. This streamlines the index file by exposing only necessary components for cleaner and more maintainable imports.
…and-env # Conflicts: # packages/twenty-front/src/generated/graphql.tsx
Removed the `isSSOEnabled` field from the GraphQL schema and related query types. This cleanup eliminates redundant data and simplifies the client config structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated all references to
isSSOEnabledacross the frontend, backend, and configuration files. This change simplifies the codebase by removing unnecessary feature flag checks, associated logic, and environment variables. The SSO feature remains available without reliance on this flag.